Skip to contentSkip to conversation

Change in openvpn[master]: fix typo in haikuos dns-updown script

Openvpn-devel New d12fk (Code Review) 2 participants 9 messages Jun 13, 2025 – Jun 18, 2025 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): gerrit.1749787477000.I48cec222d46c67e6620281cd8b2346323b546fcd@...2715...

#1 lore raw

Attention is currently required from: flichtenheld, plaisthos.

Hello plaisthos, flichtenheld,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1061?usp=email

to review the following change.

Change subject: fix typo in haikuos dns-updown script
......................................................................

fix typo in haikuos dns-updown script

Change-Id I48cec222d46c67e6620281cd8b2346323b546fcd

---
M distro/dns-scripts/haikuos_file-dns-updown.sh

1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/61/1061/1

distro/dns-scripts/haikuos_file-dns-updown.sh +1 -1
index 777b72d..6da0954 100644
@@ -28,7 +28,7 @@
 
 set -e +u
 
-conly_standard_server_ports() {
+only_standard_server_ports() {
     i=1
     while true; do
         eval addr=\"\$dns_server_${n}_address_${i}\"

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1061?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I48cec222d46c67e6620281cd8b2346323b546fcd
Gerrit-Change-Number: 1061
Gerrit-PatchSet: 1
Gerrit-Owner: d12fk <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-MessageType: newchange

#2 lore raw
In reply to a message not in the archive

Attention is currently required from: d12fk, flichtenheld, plaisthos.

cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1061?usp=email )

Change subject: fix typo in haikuos dns-updown script
......................................................................

Patch Set 1: Code-Review+2

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1061?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I48cec222d46c67e6620281cd8b2346323b546fcd
Gerrit-Change-Number: 1061
Gerrit-PatchSet: 1
Gerrit-Owner: d12fk <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Attention: d12fk <[email protected]...>
Gerrit-Comment-Date: Fri, 13 Jun 2025 11:43:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

#3 lore raw

PATCH 1/1 fix typo in haikuos dns-updown script

In reply to a message not in the archive

From: Heiko Hund <[email protected]...>

Change-Id I48cec222d46c67e6620281cd8b2346323b546fcd

---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1061
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>

distro/dns-scripts/haikuos_file-dns-updown.sh +1 -1
index 777b72d..6da0954 100644
@@ -28,7 +28,7 @@
 
 set -e +u
 
-conly_standard_server_ports() {
+only_standard_server_ports() {
     i=1
     while true; do
         eval addr=\"\$dns_server_${n}_address_${i}\"
#4 lore raw

PATCH 1/1 fix typo in haikuos dns-updown script

In reply to a message not in the archive

From: Heiko Hund <[email protected]...>

Change-Id I48cec222d46c67e6620281cd8b2346323b546fcd

---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1061
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>

distro/dns-scripts/haikuos_file-dns-updown.sh +1 -1
index 777b72d..6da0954 100644
@@ -28,7 +28,7 @@
 
 set -e +u
 
-conly_standard_server_ports() {
+only_standard_server_ports() {
     i=1
     while true; do
         eval addr=\"\$dns_server_${n}_address_${i}\"
#5 lore raw
In reply to a message not in the archive

Attention is currently required from: d12fk, flichtenheld, plaisthos.

Hello cron2, flichtenheld, plaisthos,

I'd like you to reexamine a change. Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1061?usp=email

to look at the new patch set (#2).

The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now.

Change subject: fix typo in haikuos dns-updown script
......................................................................

fix typo in haikuos dns-updown script

Change-Id I48cec222d46c67e6620281cd8b2346323b546fcd

---
M distro/dns-scripts/haikuos_file-dns-updown.sh

1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/61/1061/2

distro/dns-scripts/haikuos_file-dns-updown.sh +1 -1
index 777b72d..6da0954 100644
@@ -28,7 +28,7 @@
 
 set -e +u
 
-conly_standard_server_ports() {
+only_standard_server_ports() {
     i=1
     while true; do
         eval addr=\"\$dns_server_${n}_address_${i}\"

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1061?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I48cec222d46c67e6620281cd8b2346323b546fcd
Gerrit-Change-Number: 1061
Gerrit-PatchSet: 2
Gerrit-Owner: d12fk <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Attention: d12fk <[email protected]...>
Gerrit-MessageType: newpatchset

#6 lore raw

PATCH v2 1/1 fix typo in haikuos dns-updown script

In reply to a message not in the archive

From: Heiko Hund <[email protected]...>

Change-Id I48cec222d46c67e6620281cd8b2346323b546fcd

---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1061
This mail reflects revision 2 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>

distro/dns-scripts/haikuos_file-dns-updown.sh +1 -1
index 777b72d..6da0954 100644
@@ -28,7 +28,7 @@
 
 set -e +u
 
-conly_standard_server_ports() {
+only_standard_server_ports() {
     i=1
     while true; do
         eval addr=\"\$dns_server_${n}_address_${i}\"
#7 lore raw

[Openvpn-devel] [PATCH applied] Re: fix typo in haikuos dns-updown script

It would certainly help to actually test things on the right target platform... but this typo fix is obviously-correct.

Your patch has been applied to the master branch.

commit 51b7dc5c1093b6df82aefd464873acb9ffc93882

Author: Heiko Hund
Date:   Wed Jun 18 08:48:53 2025 +0200
     fix typo in haikuos dns-updown script

     Signed-off-by: Heiko Hund <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg31911.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#8 lore raw
In reply to a message not in the archive

cron2 has uploaded a new patch set (#3) to the change originally created by d12fk. ( http://gerrit.openvpn.net/c/openvpn/+/1061?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by cron2

Change subject: fix typo in haikuos dns-updown script
......................................................................

fix typo in haikuos dns-updown script

Change-Id I48cec222d46c67e6620281cd8b2346323b546fcd

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg31911.html

---
M distro/dns-scripts/haikuos_file-dns-updown.sh

1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/61/1061/3

distro/dns-scripts/haikuos_file-dns-updown.sh +1 -1
index 777b72d..6da0954 100644
@@ -28,7 +28,7 @@
 
 set -e +u
 
-conly_standard_server_ports() {
+only_standard_server_ports() {
     i=1
     while true; do
         eval addr=\"\$dns_server_${n}_address_${i}\"

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1061?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I48cec222d46c67e6620281cd8b2346323b546fcd
Gerrit-Change-Number: 1061
Gerrit-PatchSet: 3
Gerrit-Owner: d12fk <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset

#9 lore raw
In reply to a message not in the archive

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1061?usp=email )

Change subject: fix typo in haikuos dns-updown script
......................................................................

fix typo in haikuos dns-updown script

Change-Id I48cec222d46c67e6620281cd8b2346323b546fcd

Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg31911.html

---
M distro/dns-scripts/haikuos_file-dns-updown.sh

1 file changed, 1 insertion(+), 1 deletion(-)
distro/dns-scripts/haikuos_file-dns-updown.sh +1 -1
index 777b72d..6da0954 100644
@@ -28,7 +28,7 @@
 
 set -e +u
 
-conly_standard_server_ports() {
+only_standard_server_ports() {
     i=1
     while true; do
         eval addr=\"\$dns_server_${n}_address_${i}\"

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1061?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I48cec222d46c67e6620281cd8b2346323b546fcd
Gerrit-Change-Number: 1061
Gerrit-PatchSet: 3
Gerrit-Owner: d12fk <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged